Abstract: Using 55 clones of Dagujia Pinus koraiensis seed garden as materials, the genetic variation of growth and seed traits and genetic parameters were investigated to carry out excellent clone breeding. The results showed that there were significant differences in growth and seed traits among the tested P. koraiensis clone populations(P < 0.01). The results showed that there were significant differences in each character among the clones (p < 0.01). The genetic variation coefficients of growth and seed traits ranged from 4.43% to 16.85% and 3.06% to 45.87%, the phenotypic variation coefficients ranged from 5.02% to 18.91% and 3.25% to 56.13, and the repeatability ranged from 0.54 to 0.79 and 0.44 to 0.98, respectively.. The average genetic and phenotypic variation coefficient of the selected traits were 17.96% and 22.03%, and the average repeatability was 0.77, with high variability and high repeatability. Correlation analysis showed that there were different degrees of positive correlation among the selected traits. The genetic gain of 6 excellent fruit and wood dual-purpose clones selected by membership function method with 10% selection rate was 2.15% (thousand kernel weight) −169.62%(seed weight per plant), and the average value was as high as 49.31%.